Skip to content

Landing page oss #27979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karanh37 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Landing page oss #27979

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a2755d
Update AnnouncementsWidgetV2.component.tsx
karanh37 May 8, 2026
9c4b178
update usage
karanh37 May 8, 2026
39498bd
fix: stabilize announcements type prop and move type alias after imports
gitar-bot May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions .../src/components/DataMarketplace/AnnouncementsWidgetV2/AnnouncementsWidgetV2.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ import {
AnnouncementEntity,
getActiveAnnouncements,
} from '../../../rest/announcementsAPI';

type AnnouncementsWidgetV2Props = WidgetCommonProps & {
type?: EntityType[];
};
Comment thread
gitar-bot[bot] marked this conversation as resolved.
Outdated
import {
getEntityFQN,
getEntityType,
Expand Down Expand Up @@ -62,7 +66,10 @@ const DUMMY_ANNOUNCEMENTS: AnnouncementEntity[] = [
},
];

const AnnouncementsWidgetV2 = ({ isEditView }: WidgetCommonProps) => {
const AnnouncementsWidgetV2 = ({
isEditView,
type,
}: AnnouncementsWidgetV2Props) => {
const { t } = useTranslation();
const navigate = useNavigate();
const [announcements, setAnnouncements] = useState<AnnouncementEntity[]>(
Expand All @@ -79,17 +86,17 @@ const AnnouncementsWidgetV2 = ({ isEditView }: WidgetCommonProps) => {
try {
const res = await getActiveAnnouncements();
const filtered = (res.data ?? []).filter((announcement) => {
const type = getEntityType(announcement.entityLink ?? '');
const entityType = getEntityType(announcement.entityLink ?? '');

return type === EntityType.DOMAIN || type === EntityType.DATA_PRODUCT;
return type ? type.includes(entityType as EntityType) : true;
});
setAnnouncements(filtered);
} catch {
setAnnouncements([]);
} finally {
setLoading(false);
}
}, [isEditView]);
}, [isEditView, type]);

useEffect(() => {
fetchAnnouncements();
Expand Down
5 changes: 4 additions & 1 deletion ...-ui/src/main/resources/ui/src/pages/DataMarketplacePage/DataMarketplacePage.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,10 @@ const DataMarketplacePage = () => {
</div>
<div className="marketplace-grid-wrapper" dir="ltr">
<div className="p-x-box">
<AnnouncementsWidgetV2 widgetKey="announcements" />
<AnnouncementsWidgetV2
type={[EntityType.DOMAIN, EntityType.DATA_PRODUCT]}
Comment thread
gitar-bot[bot] marked this conversation as resolved.
Outdated
widgetKey="announcements"
/>
Comment on lines +147 to +150
Comment on lines +147 to +150
</div>
<ReactGridLayout
className="grid-container p-x-box"
Expand Down
Loading