Skip to content

Migrate IncidentManager table to core-ui Table component #27972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shah-harshit merged 9 commits into from
May 9, 2026
Merged

Migrate IncidentManager table to core-ui Table component #27972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0dd4d6e
refactor(IncidentManager): migrate table to core-ui Table component
shah-harshit May 7, 2026
b09bfdf
fix checkstyle
shah-harshit May 7, 2026
749cd63
address gitar-bot comments
shah-harshit May 7, 2026
4cc785e
Merge branch 'main' into feat/migrate-incident-manager-table-core-ui
shah-harshit May 7, 2026
c657dfc
address comments
shah-harshit May 8, 2026
dfb03d9
fix checkstyle
shah-harshit May 8, 2026
809a69c
Merge branch 'main' into feat/migrate-incident-manager-table-core-ui
satender-kumar-collate May 8, 2026
f7d8210
Merge branch 'main' into feat/migrate-incident-manager-table-core-ui
shah-harshit May 8, 2026
11e13ef
Fix incident manager tests
shah-harshit May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/IncidentManager.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ const isVisible = async (locator: Locator) =>

const expectIncidentTableRowsToContain = async (page: Page, text: string) => {
const rows = page.locator(
'.ant-table-tbody tr:not(.ant-table-measure-row):not(.ant-table-placeholder)'
'[data-testid="test-case-incident-manager-table"] tbody tr'
);
const rowCount = await rows.count();

Expand Down Expand Up @@ -851,9 +851,7 @@ test.describe('Incident Manager', PLAYWRIGHT_INGESTION_TAG_OBJ, () => {
page.locator(`[data-testid="status-badge-${testCaseName}"]`)
).toContainText('Failed');

await page.click(
`[data-testid="${testCaseName}"] >> text=${testCaseName}`
);
await page.getByTestId(testCaseName).getByText(testCaseName).click();
await expect(page.getByTestId('entity-page-header')).toBeVisible();
await openIncidentTaskTab(page);
await page.click('[data-testid="closed-task"]');
Expand Down
14 changes: 7 additions & 7 deletions openmetadata-ui/src/main/resources/ui/playwright/utils/incidentManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,20 +42,20 @@ export const acknowledgeTask = async (data: {
page.locator(`[data-testid="status-badge-${testCase}"]`)
).toContainText('Failed');

await page
.locator(`[data-testid="${testCase}-status"] >> text=New`)
.waitFor();
await page.click(`[data-testid="${testCase}"] >> text=${testCase}`);
await expect(
page.locator(`[data-testid="${testCase}-status"]`)
).toContainText('New');
await page.getByTestId(testCase).getByText(testCase).click();
await waitForAllLoadersToDisappear(page);
await page.click('[data-testid="edit-resolution-icon"]');
await page.click('[data-testid="test-case-resolution-status-type"]');
await page.click('[title="Ack"]');
const statusChangeResponse = waitForTaskResolveResponse(page);
await page.click('#update-status-button');
await statusChangeResponse;
await page
.locator(`[data-testid="${testCase}-status"] >> text=Ack`)
.waitFor();
await expect(
page.locator(`[data-testid="${testCase}-status"]`)
).toContainText('Ack');

await expect(
page.locator(
Expand Down
7 changes: 6 additions & 1 deletion ...identManager/TestCaseStatus/InlineIncidentStatus/IncidentStatusPopoverShell.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ export type IncidentStatusPopoverShellProps = {
dataTestid: string;
trigger: ReactNode;
children: ReactNode;
popoverClassName?: string;
};

export const IncidentStatusPopoverShell = ({
Expand All @@ -30,10 +31,14 @@ export const IncidentStatusPopoverShell = ({
dataTestid,
trigger,
children,
popoverClassName,
}: IncidentStatusPopoverShellProps) => (
<PopoverTrigger isOpen={isOpen} onOpenChange={onOpenChange}>
{trigger}
<Popover containerClassName={containerClassName} data-testid={dataTestid}>
<Popover
className={popoverClassName}
containerClassName={containerClassName}
data-testid={dataTestid}>
{children}
</Popover>
</PopoverTrigger>
Expand Down
6 changes: 4 additions & 2 deletions ...nts/DataQuality/IncidentManager/TestCaseStatus/InlineTestCaseIncidentStatus.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,6 +569,7 @@ const InlineTestCaseIncidentStatus = ({
containerClassName="tw:max-h-[500px] tw:min-w-0 tw:w-[320px] tw:border tw:border-border-secondary"
dataTestid={`${data.testCaseReference?.name}-assignee-popover`}
isOpen={showAssigneePopover}
popoverClassName="tw:!max-h-none"
trigger={renderStatusChipButton()}
onOpenChange={(open) => {
if (open) {
Expand All @@ -586,9 +587,10 @@ const InlineTestCaseIncidentStatus = ({
if (showResolvedPopover) {
return (
<IncidentStatusPopoverShell
containerClassName="tw:min-w-0 tw:w-[320px] tw:border tw:border-border-secondary"
containerClassName="tw:min-w-0 tw:w-80 tw:overflow-y-auto tw:border tw:border-border-secondary"
dataTestid={`${data.testCaseReference?.name}-resolved-popover`}
isOpen={showResolvedPopover}
popoverClassName="tw:!max-h-none"
trigger={renderStatusChipButton()}
onOpenChange={(open) => {
if (!open) {
Expand All @@ -611,7 +613,7 @@ const InlineTestCaseIncidentStatus = ({
onOpenChange={handleStatusMenuOpenChange}>
{renderStatusChipButton()}
<Dropdown.Popover
className="tw:min-w-[100px] tw:w-max tw:overflow-auto"
className="tw:min-w-25 tw:w-max tw:overflow-auto"
placement="top">
{statusMenuItems}
</Dropdown.Popover>
Expand Down
Loading
Loading