Skip to content

fix: multiprovider parity gaps with JS SDK reference (#1882) #1897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jonathannorris wants to merge 8 commits into
base: main
Choose a base branch
from

refactor: simplify multiprovider code per review

586f4c6
Select commit
Loading
Failed to load commit list.
Draft

fix: multiprovider parity gaps with JS SDK reference (#1882) #1897

refactor: simplify multiprovider code per review
586f4c6
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded May 8, 2026 in 21s

Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 627 in src/main/java/dev/openfeature/sdk/multiprovider/MultiProvider.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "providerHooks" which hides the field declared at line 104. 

See more on https://sonarcloud.io/project/issues?id=open-feature_java-sdk&issues=AZ4I4Xm3bgnSuG7_g7Th&open=AZ4I4Xm3bgnSuG7_g7Th&pullRequest=1897

Check failure on line 95 in src/main/java/dev/openfeature/sdk/multiprovider/ComparisonStrategy.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 20 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=open-feature_java-sdk&issues=AZ4I0vsHn67pI1HeG1OB&open=AZ4I0vsHn67pI1HeG1OB&pullRequest=1897

Check warning on line 619 in src/main/java/dev/openfeature/sdk/multiprovider/MultiProvider.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 121 to 64, Complexity from 17 to 14, Nesting Level from 4 to 2, Number of Variables from 28 to 6. 

See more on https://sonarcloud.io/project/issues?id=open-feature_java-sdk&issues=AZ4I0vs-n67pI1HeG1OG&open=AZ4I0vs-n67pI1HeG1OG&pullRequest=1897

Check warning on line 690 in src/main/java/dev/openfeature/sdk/multiprovider/MultiProvider.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=open-feature_java-sdk&issues=AZ4I0vs-n67pI1HeG1OD&open=AZ4I0vs-n67pI1HeG1OD&pullRequest=1897

Check failure on line 619 in src/main/java/dev/openfeature/sdk/multiprovider/MultiProvider.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 29 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=open-feature_java-sdk&issues=AZ4I0vs-n67pI1HeG1OF&open=AZ4I0vs-n67pI1HeG1OF&pullRequest=1897

Check warning on line 86 in src/test/java/dev/openfeature/sdk/multiprovider/MultiProviderTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Consume or remove this unused collection 

See more on https://sonarcloud.io/project/issues?id=open-feature_java-sdk&issues=AZ4I0vnHn67pI1HeG1OA&open=AZ4I0vnHn67pI1HeG1OA&pullRequest=1897
View more details on SonarQubeCloud