Skip to content

Minor improvements to DarkSword - #953

Open
st0rmsetter wants to merge 2 commits into
opa334:3.xfrom
st0rmsetter:patch-1
Open

Minor improvements to DarkSword#953
st0rmsetter wants to merge 2 commits into
opa334:3.xfrom
st0rmsetter:patch-1

Conversation

@st0rmsetter

@st0rmsetter st0rmsetter commented Aug 14, 2026

Copy link
Copy Markdown
  1. Removed the setTargetKaddr function, a near-identical clone of the actual set_target_kaddr function that wasn't called anywhere in the code
  2. Fixed crucial error handling oversight that checked the surface variable instead of checking the success of mach_make_memory_entry_64 function like it is supposed to
  3. Removed unused xpc/xpc.h import

These changes should generally make the code better

Removed dead code and fixed incorrect error handling.
@st0rmsetter
st0rmsetter marked this pull request as draft August 15, 2026 18:11
@st0rmsetter
st0rmsetter marked this pull request as ready for review August 15, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant