Fix libnatpmp vcpkg port#709
Merged
Merged
Conversation
mrannanj
reviewed
Oct 31, 2024
mrannanj
approved these changes
Nov 1, 2024
Member
Author
|
note that the target branch of this PR is @Vagabond's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The link issue was because the MINIUPNP_STATICLIB and NATPMP_STATICLIB defines weren't being propogated from the dependency into openomf_core, which caused the headers to misbehave (and think they were part of a DLL build)
By linking to an imported cmake target we can be certain that any PUBLIC target_add_definitions in the libraries get to the openomf target we are linking them to, here openomf_core.
Unfortunately, ubuntu's libminiupnpc-dev does not ship an exported cmake target (they are probably using the Makefile to build their package); if they did ship an exported cmake target, we would be able to rid ourselves of the Findminiupnpc.cmake script entirely and rely on find_package(CONFIG).