[IMP] runbot: create database inside docker#1432
Open
Xavier-Do wants to merge 1 commit into
Open
Conversation
Xavier-Do
commented
Jun 16, 2026
| db_suffix = re.sub(r'[^a-z0-9\-_]', '_', db_suffix.lower()) | ||
| db_name = '%s-%s' % (build.dest, db_suffix) | ||
| if modules_to_install and self.create_db: | ||
| build._local_pg_createdb(db_name) |
Contributor
Author
There was a problem hiding this comment.
This is not really needed since runbot will pass the db-template in the config.
There are also no known case where we want to automatically drop a database with the same name silently, should be done explicitly.
Xavier-Do
force-pushed
the
19.0-no-create-db-xdo
branch
from
bcbaeea to
29aaad8
Compare
To allow to run postgress in docker we cannot make any maintenance on database from outside the docker anymore, meaning that the database creations needs to be done in the docker.
Xavier-Do
force-pushed
the
19.0-no-create-db-xdo
branch
from
29aaad8 to
992ffa0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To allow to run postgres in docker we cannot make any maintenance on database from outside the docker anymore, meaning that the database creations needs to be done in the docker.