Skip to content

plugins: Fix missing file descriptors #13470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WizardCM wants to merge 3 commits into
base: master
Choose a base branch
from
+59 −1
Open

plugins: Fix missing file descriptors #13470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db8b532
obs-webrtc: Build with file descriptor
WizardCM May 25, 2026
62409ea
obs-vst: Build with file descriptor
WizardCM May 25, 2026
c6f9311
win-capture: Build with file descriptor
WizardCM May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions plugins/obs-vst/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ target_link_libraries(
)

if(OS_WINDOWS)
configure_file(cmake/windows/obs-module.rc.in obs-vst.rc)
target_sources(obs-vst PRIVATE obs-vst.rc)
set_property(TARGET obs-vst APPEND PROPERTY AUTORCC_OPTIONS --format-version 1)
endif()

Expand Down
24 changes: 24 additions & 0 deletions plugins/obs-vst/cmake/windows/obs-module.rc.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
1 VERSIONINFO
FILEVERSION ${OBS_VERSION_MAJOR},${OBS_VERSION_MINOR},${OBS_VERSION_PATCH},0
BEGIN
BLOCK "StringFileInfo"
BEGIN
BLOCK "040904B0"
BEGIN
VALUE "CompanyName", "${OBS_COMPANY_NAME}"
VALUE "FileDescription", "OBS VST2 module"
VALUE "FileVersion", "${OBS_VERSION_CANONICAL}"
VALUE "ProductName", "${OBS_PRODUCT_NAME}"
VALUE "ProductVersion", "${OBS_VERSION_CANONICAL}"
VALUE "Comments", "${OBS_COMMENTS}"
VALUE "LegalCopyright", "${OBS_LEGAL_COPYRIGHT}"
VALUE "InternalName", "obs-vst"
VALUE "OriginalFilename", "obs-vst"
END
END

BLOCK "VarFileInfo"
BEGIN
VALUE "Translation", 0x0409, 0x04B0
END
END
5 changes: 5 additions & 0 deletions plugins/obs-webrtc/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,9 @@ target_sources(

target_link_libraries(obs-webrtc PRIVATE OBS::libobs LibDataChannel::LibDataChannel CURL::libcurl)

if(OS_WINDOWS)
configure_file(cmake/windows/obs-module.rc.in obs-webrtc.rc)
target_sources(obs-webrtc PRIVATE obs-webrtc.rc)
endif()

set_target_properties_obs(obs-webrtc PROPERTIES FOLDER plugins PREFIX "")
2 changes: 1 addition & 1 deletion plugins/obs-webrtc/cmake/windows/obs-module.rc.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ BEGIN
BLOCK "040904B0"
BEGIN
VALUE "CompanyName", "${OBS_COMPANY_NAME}"
VALUE "FileDescription", "OBS output module"
VALUE "FileDescription", "OBS WebRTC module"
VALUE "FileVersion", "${OBS_VERSION_CANONICAL}"
VALUE "ProductName", "${OBS_PRODUCT_NAME}"
VALUE "ProductVersion", "${OBS_VERSION_CANONICAL}"
Expand Down
3 changes: 3 additions & 0 deletions plugins/win-capture/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@ target_link_libraries(
# Remove once jansson has been fixed on obs-deps
target_link_options(win-capture PRIVATE /IGNORE:4098)

configure_file(cmake/windows/obs-module.rc.in win-capture.rc)
target_sources(win-capture PRIVATE win-capture.rc)

set_target_properties_obs(win-capture PROPERTIES FOLDER plugins/win-capture PREFIX "")

add_subdirectory(graphics-hook)
Expand Down
24 changes: 24 additions & 0 deletions plugins/win-capture/cmake/windows/obs-module.rc.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
1 VERSIONINFO
FILEVERSION ${OBS_VERSION_MAJOR},${OBS_VERSION_MINOR},${OBS_VERSION_PATCH},0
BEGIN
BLOCK "StringFileInfo"
BEGIN
BLOCK "040904B0"
BEGIN
VALUE "CompanyName", "${OBS_COMPANY_NAME}"
VALUE "FileDescription", "OBS Windows Capture module"
VALUE "FileVersion", "${OBS_VERSION_CANONICAL}"
VALUE "ProductName", "${OBS_PRODUCT_NAME}"
VALUE "ProductVersion", "${OBS_VERSION_CANONICAL}"
VALUE "Comments", "${OBS_COMMENTS}"
VALUE "LegalCopyright", "${OBS_LEGAL_COPYRIGHT}"
VALUE "InternalName", "win-capture"
VALUE "OriginalFilename", "win-capture"
END
END

BLOCK "VarFileInfo"
BEGIN
VALUE "Translation", 0x0409, 0x04B0
END
END
Loading