refactor: cleanup Takumi glue code#490
Merged
harlan-zw merged 4 commits intonuxt-modules:mainfrom Feb 28, 2026
Merged
Conversation
Collaborator
|
Thanks for the help, much appreicated. |
Collaborator
|
Looks like a small regression in here if we have an SVG like so: <img
src="/logo-icon.svg"
width="60"
height="60"
alt="npmx logo"
/>It won't respect the width/height attributes and instead uses the width/height on the SVG. Have to add explicit width / heihgt with style to fix. |
Contributor
Author
May I know what version did you used? |
Contributor
Author
|
@harlan-zw fixed in 0.70.2! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
npmx-dev/npmx.dev#1654
#435
❓ Type of change
📚 Description
Takumi has built-in
color-mix()#435
Uint8Arraynot owned