Allow sebastian/diff ^8.0 and ^9.0 - #741
Open
edgrosvenor wants to merge 1 commit into
Open
Conversation
Differ.php only uses SebastianBergmann\Diff\Differ and StrictUnifiedDiffOutputBuilder, and never passes the $lcs parameter. Both survive in 9.0 — what 9.0 removed (UnifiedDiffOutputBuilder, AbstractChunkOutputBuilder, the LongestCommonSubsequenceCalculator interface and the $lcs parameter) is unused here. Without this, phpinsights blocks consumers from moving to PHPUnit 13 / Pest 5, which require sebastian/diff ^9.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Domain/Differ.phpuses onlySebastianBergmann\Diff\DifferandStrictUnifiedDiffOutputBuilder, and never passes the$lcsparameter — so nothing it touches was affected by the 9.0 removals (UnifiedDiffOutputBuilder,AbstractChunkOutputBuilder, theLongestCommonSubsequenceCalculatorinterface and its implementations, and the$lcsparameter).Without this, phpinsights transitively blocks consumers from upgrading to PHPUnit 13 / Pest 5, which require
sebastian/diff ^9.0.Constraint-only change; no source changes.
Related: cmgmyr/phploc#13 is the other half — phploc caps
php-file-iteratorat ^6, which blocks the same upgrade.🤖 Generated with Claude Code