Préférences: à la connexion, après l'activation des notifications emmener l'usager sur l'écran des zones#848
Open
zebuline wants to merge 1 commit into
Open
Préférences: à la connexion, après l'activation des notifications emmener l'usager sur l'écran des zones#848zebuline wants to merge 1 commit into
zebuline wants to merge 1 commit into
Conversation
magopian
approved these changes
May 4, 2026
Collaborator
magopian
left a comment
There was a problem hiding this comment.
Yep, excellent, merci !
J'espère que ça va pas être lourd pour l'utilisateur : je lance l'appli PAF popup pour activer les notifications.
Je la ferme, énervé, et PAF popup pour choisir les zones 😬
🚢
cdesquilbet-dila
approved these changes
May 11, 2026
Collaborator
cdesquilbet-dila
left a comment
There was a problem hiding this comment.
Merci ! Tout fonctionne très bien.
(C'est probablement sur la maquette, mais j'ai trouvé le libellé "Passer" pas très juste, parce qu'on peut ajuster des préférences avec les toggles, qui seront prises en compte, mais on est obligés d'appuyer sur "Passer" pour sortir de la page)
| await initializeData(page.url.searchParams, userStore); | ||
| if (page.url.searchParams.get('user_first_login') === 'true') { | ||
| goto('/#/notifications-welcome-page'); | ||
| goto('/#/welcome/notifications'); |
Collaborator
There was a problem hiding this comment.
Est-ce qu'il faut prévenir Aline et Nico que l'url a changé ?
Collaborator
Author
There was a problem hiding this comment.
effectivement, je vais gérer la compatibilité
e9f60f1 to
9a22cf5
Compare
9a22cf5 to
1805c31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #788