Integrates playwright in cucumber e2e tests#237
Open
edouard-gv wants to merge 8 commits into
Open
Conversation
Collaborator
Author
|
J'ai un problème de linter qui ne veut pas se lancer sur ma machine :-(. |
magopian
approved these changes
Nov 17, 2025
Collaborator
magopian
left a comment
magopian
left a comment
There was a problem hiding this comment.
Looks great, thanks.
Do we want to add those in the CI? We could change the npm run test to be
"test": "npm run test:unit -- --run && npm run test:e2e && npm run test:cucumber",What do you think?
| //{ headless: false, slowMo: 1500} | ||
| ); | ||
| browserContext = await browser.newContext( | ||
| //{baseURL: "https://localhost:4173/", ignoreHTTPSErrors: true} |
Collaborator
There was a problem hiding this comment.
Nit: do we need to keep this comment?
Collaborator
Author
|
Je crée le ticket :).
… Le 17/11/2025 10:18 CET, Mathieu Agopian ***@***.***> a écrit :
@magopian approved this pull request.
Looks great, thanks.
Do we want to add those in the CI? We could change the npm run test to be
"test": "npm run test:unit -- --run && npm run test:e2e && npm run test:cucumber",
What do you think?
---------------------------------------------
In public/mobile-app/tests/features/step_definitions/default-steps.cjs #237 (comment):
> +
+const { chromium, expect, defineConfig } = ***@***.***/test");
+
+const { Page } = require("playwright");
+
+setDefaultTimeout(60 * 1000);
+
+let page, browserContext, browser;
+
+Before(async function () {
+ browser = await chromium.launch(
+ //uncomment this line to see the tests in live
+ //{ headless: false, slowMo: 1500}
+ );
+ browserContext = await browser.newContext(
+ //{baseURL: "https://localhost:4173/", ignoreHTTPSErrors: true}
Nit: do we need to keep this comment?
—
Reply to this email directly, view it on GitHub #237 (review), or unsubscribe https://github.com/notifications/unsubscribe-auth/AASX64Z542RRLKTGACITNHD35GHEZAVCNFSM6AAAAACLVZZW4OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTINZRG42TQMRWGI.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.