Skip to content

feat: preview mode show the pr number #1729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 6 commits into from
Feb 28, 2026
Merged

feat: preview mode show the pr number #1729

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8bd6057
feat: preview mode show the pr number
btea Feb 28, 2026
087fc17
feat: update
btea Feb 28, 2026
0a79d95
feat: apply review
btea Feb 28, 2026
e2df8ab
feat: update
btea Feb 28, 2026
fe474ab
feat: update
btea Feb 28, 2026
b2de7a0
feat: apply review
btea Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions app/components/AppHeader.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ const mobileLinks = computed<NavigationConfigWithGroups>(() => [
const showFullSearch = shallowRef(false)
const showMobileMenu = shallowRef(false)
const { env } = useAppConfig().buildInfo
const prId = env === 'preview' ? useRuntimeConfig().public.pullRequestID : undefined
Comment thread
btea marked this conversation as resolved.
Outdated

// On mobile, clicking logo+search button expands search
const route = useRoute()
Expand Down Expand Up @@ -227,6 +228,15 @@ onKeyStroke(
{{ env === 'release' ? 'alpha' : env }}
</span>
</NuxtLink>
<NuxtLink
v-if="prId"
:to="`https://github.com/npmx-dev/npmx.dev/pull/${prId}`"
:aria-label="`Open GitHub pull request ${prId}`"
>
<span class="text-xs px-1.5 py-0.5 rounded badge-green font-sans font-medium ms-2">
PR #{{ prId }}
</span>
</NuxtLink>
</div>
<!-- Spacer when logo is hidden on desktop -->
<span v-else class="hidden sm:block w-1" />
Expand Down
1 change: 1 addition & 0 deletions nuxt.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ export default defineNuxtConfig({
apiKey: 'f54e21fa3a2a0160595bb058179bfb1e',
indexName: 'npm-search',
},
pullRequestID: process.env.VERCEL_GIT_PULL_REQUEST_ID || undefined,
Comment thread
btea marked this conversation as resolved.
Outdated
},
},

Expand Down
Loading