Skip to content

fix: address CLS in downloads modal #1619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphieros merged 3 commits into from
Feb 24, 2026
Merged

fix: address CLS in downloads modal #1619

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5519ca3
fix: address CLS in downloads modal
graphieros Feb 24, 2026
a1fa4f2
fix: address CLS, add skeleton
graphieros Feb 24, 2026
27ae458
fix: apply coderabbit suggestion
graphieros Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/components/Package/TrendsChart.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1682,7 +1682,11 @@ watch(selectedMetric, value => {
</h2>

<!-- Chart panel (active metric) -->
<div role="region" aria-labelledby="trends-chart-title" class="min-h-[260px]">
<div
role="region"
aria-labelledby="trends-chart-title"
:class="isMobile ? 'min-h-[260px]' : 'min-h-[567px]'"
>
Comment thread
graphieros marked this conversation as resolved.
<ClientOnly v-if="chartData.dataset">
<div :data-pending="pending" :data-minimap-visible="maxDatapoints > 6">
<VueUiXy
Expand Down
5 changes: 1 addition & 4 deletions app/components/Package/WeeklyDownloadStats.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,10 +351,7 @@ const config = computed<VueUiSparklineConfig>(() => {

<!-- This placeholder bears the same dimensions as the PackageTrendsChart component -->
<!-- Avoids CLS when the dialog has transitioned -->
<div
v-if="!hasChartModalTransitioned"
class="w-full aspect-[390/634.5] sm:aspect-[718/622.797]"
/>
<div v-if="!hasChartModalTransitioned" class="w-full aspect-[390/634.5] sm:aspect-[718/647]" />
</PackageChartModal>
</template>

Expand Down
Loading