Skip to content

fix: restore default cursor and add commitment in docs #1261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexdln merged 7 commits into from
Feb 13, 2026
Merged

fix: restore default cursor and add commitment in docs #1261

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3360030
fix: restore the return cursor and delete the cursor of the basic but…
kalu5 Feb 9, 2026
028de72
Merge branch 'main' into fix/#1074
kalu5 Feb 10, 2026
a854ea8
Merge branch 'main' into fix/#1074
alexdln Feb 13, 2026
0d1a725
chore: describe cursor and navigation in contributing guide
alexdln Feb 13, 2026
2414cc0
chore: add anchor to contributing guide
alexdln Feb 13, 2026
445af2a
chore: fix order in contributing guide
alexdln Feb 13, 2026
637ef09
chore: update cursor and navigation guidance
alexdln Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ This focus helps guide our project decisions as a community and what we choose t
- [Naming conventions](#naming-conventions)
- [Vue components](#vue-components)
- [Internal linking](#internal-linking)
- [Cursor and navigation](#cursor-and-navigation)
- [RTL Support](#rtl-support)
- [Localization (i18n)](#localization-i18n)
- [Approach](#approach)
Expand Down Expand Up @@ -392,6 +393,22 @@ For package links, use the auto-imported `packageRoute()` utility from `app/util
| `~username` | `/~:username` | `username` |
| `~username-orgs` | `/~:username/orgs` | `username` |

### Cursor and navigation

We prefer consistency in user everyday experience

npmx uses `cursor-pointer` only for links. For all other elements, including buttons, use the default cursor (_or other appropriate cursors to show state_).

Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
**What counts as a link**

A link is any element that change or show meaningful content:

- **Not meaningful content:** burger menu, "likes" button - the user does not get substantive information from them.
- **Meaningful content:** a dialog with a chart, auth button, tabs with new data—they convey new or important information.

Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
Comment thread
alexdln marked this conversation as resolved.
> [!IMPORTANT]
> Always prefer implementing such changes as real links so they can be opened in a new tab, shared or reloaded, and so the same content is available at a stable URL.

## RTL Support

We support `right-to-left` languages, we need to make sure that the UI is working correctly in both directions.
Expand Down
2 changes: 1 addition & 1 deletion app/components/Button/Base.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ defineExpose({
<template>
<button
ref="el"
class="group cursor-pointer gap-x-1 items-center justify-center font-mono border border-border rounded-md transition-all duration-200 disabled:(opacity-40 cursor-not-allowed border-transparent)"
class="group gap-x-1 items-center justify-center font-mono border border-border rounded-md transition-all duration-200 disabled:(opacity-40 cursor-not-allowed border-transparent)"
:class="{
'inline-flex': !block,
'flex': block,
Expand Down
Loading