Skip to content

feat(ui): add mobile buttons for package nav, and wrap badges #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhalp merged 3 commits into from
Feb 8, 2026
Merged

feat(ui): add mobile buttons for package nav, and wrap badges #1188

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a5e1b0
feat: add mobile buttons for package nav, and wrap badges
danielroe Feb 8, 2026
437fa51
chore: tidy comments
danielroe Feb 8, 2026
0ae62d3
chore: rtl class
danielroe Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/components/Package/Skeleton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
>
<!-- Package header — matches area-header in [...name].vue -->
<header class="area-header sticky top-14 z-1 bg-[--bg] py-2">
<div class="flex items-baseline gap-2 sm:gap-3 flex-wrap min-w-0">
<div class="flex items-baseline gap-x-2 gap-y-1 sm:gap-x-3 flex-wrap min-w-0">
<!-- Package name -->
<div class="min-w-0">
<h1 class="font-mono text-2xl sm:text-3xl font-medium">
Expand All @@ -19,8 +19,8 @@
<span class="inline-flex items-baseline font-mono text-base sm:text-lg shrink-0">
<SkeletonInline class="h-6 w-20" />
</span>
<!-- Metrics badges placeholder -->
<div class="flex items-center gap-1.5 relative top-[5px] self-baseline ms-1 sm:ms-2">
<!-- Metrics badges -->
<div class="basis-full flex items-center gap-1.5 self-baseline">
<SkeletonBlock class="w-16 h-5.5 rounded" />
<SkeletonBlock class="w-13 h-5.5 rounded" />
<SkeletonBlock class="w-13 h-5.5 rounded" />
Expand Down
117 changes: 54 additions & 63 deletions app/pages/package/[[org]]/[name].vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,7 @@ onKeyStroke(
:class="{ 'border-b': isHeaderPinned }"
>
<!-- Package name and version -->
<div class="flex items-baseline gap-2 sm:gap-3 flex-wrap min-w-0">
<div class="flex items-baseline gap-x-2 gap-y-1 sm:gap-x-3 flex-wrap min-w-0">
<div class="group relative flex flex-col items-start min-w-0">
<h1
class="font-mono text-2xl sm:text-3xl font-medium min-w-0 break-words"
Expand Down Expand Up @@ -605,15 +605,49 @@ onKeyStroke(
>
</span>

<!-- Package metrics (module format, types) -->
<div class="flex gap-2 sm:gap-3 flex-wrap">
<!-- Docs + Code + Compare — inline on desktop, floating bottom bar on mobile -->
<ButtonGroup
v-if="resolvedVersion"
as="nav"
:aria-label="$t('package.navigation')"
class="package-nav hidden sm:flex max-sm:flex max-sm:fixed max-sm:z-40 max-sm:left-50% max-sm:-translate-x-50% max-sm:bg-[--bg]/90 max-sm:backdrop-blur-md max-sm:border max-sm:border-border max-sm:rounded-md max-sm:shadow-md"
>
<LinkBase
variant="button-secondary"
v-if="docsLink"
:to="docsLink"
keyshortcut="d"
classicon="i-carbon:document"
>
{{ $t('package.links.docs') }}
</LinkBase>
<LinkBase
variant="button-secondary"
:to="{ name: 'code', params: { path: [pkg.name, 'v', resolvedVersion] } }"
keyshortcut="."
classicon="i-carbon:code"
>
{{ $t('package.links.code') }}
</LinkBase>
<LinkBase
variant="button-secondary"
:to="{ name: 'compare', query: { packages: pkg.name } }"
keyshortcut="c"
classicon="i-carbon:compare"
>
{{ $t('package.links.compare') }}
</LinkBase>
</ButtonGroup>
Comment thread
coderabbitai[bot] marked this conversation as resolved.

<!-- Package metrics -->
<div class="basis-full flex gap-2 sm:gap-3 flex-wrap">
<ClientOnly>
<PackageMetricsBadges
v-if="resolvedVersion"
:package-name="pkg.name"
:version="resolvedVersion"
:is-binary="isBinaryOnly"
class="self-baseline ms-1 sm:ms-2"
class="self-baseline"
/>

<!-- Package likes -->
Expand Down Expand Up @@ -654,9 +688,7 @@ onKeyStroke(
</ButtonBase>
</TooltipApp>
<template #fallback>
<div
class="flex items-center gap-1.5 list-none m-0 p-0 relative top-[5px] self-baseline ms-1 sm:ms-2"
>
<div class="flex items-center gap-1.5 list-none m-0 p-0 self-baseline">
<SkeletonBlock class="w-16 h-5.5 rounded" />
<SkeletonBlock class="w-13 h-5.5 rounded" />
<SkeletonBlock class="w-13 h-5.5 rounded" />
Expand All @@ -665,40 +697,6 @@ onKeyStroke(
</template>
</ClientOnly>
</div>

<!-- Internal navigation: Docs + Code + Compare (hidden on mobile, shown in external links instead) -->
<ButtonGroup
v-if="resolvedVersion"
as="nav"
:aria-label="$t('package.navigation')"
class="hidden sm:flex"
>
<LinkBase
variant="button-secondary"
v-if="docsLink"
:to="docsLink"
keyshortcut="d"
classicon="i-carbon:document"
>
{{ $t('package.links.docs') }}
</LinkBase>
<LinkBase
variant="button-secondary"
:to="{ name: 'code', params: { path: [pkg.name, 'v', resolvedVersion] } }"
keyshortcut="."
classicon="i-carbon:code"
>
{{ $t('package.links.code') }}
</LinkBase>
<LinkBase
variant="button-secondary"
:to="{ name: 'compare', query: { packages: pkg.name } }"
keyshortcut="c"
classicon="i-carbon:compare"
>
{{ $t('package.links.compare') }}
</LinkBase>
</ButtonGroup>
</div>
</header>

Expand Down Expand Up @@ -770,28 +768,6 @@ onKeyStroke(
{{ $t('package.links.fund') }}
</LinkBase>
</li>
<!-- Mobile-only: Docs + Code + Compare links -->
<li v-if="docsLink && displayVersion" class="sm:hidden">
<LinkBase :to="docsLink" classicon="i-carbon:document">
{{ $t('package.links.docs') }}
</LinkBase>
</li>
<li v-if="resolvedVersion" class="sm:hidden">
<LinkBase
:to="{ name: 'code', params: { path: [pkg.name, 'v', resolvedVersion] } }"
classicon="i-carbon:code"
>
{{ $t('package.links.code') }}
</LinkBase>
</li>
<li class="sm:hidden">
<LinkBase
:to="{ name: 'compare', query: { packages: pkg.name } }"
classicon="i-carbon:compare"
>
{{ $t('package.links.compare') }}
</LinkBase>
</li>
</ul>
</div>

Expand Down Expand Up @@ -1373,4 +1349,19 @@ onKeyStroke(
display: none;
}
}

/* Mobile floating nav: safe-area positioning + kbd hiding */
@media (max-width: 639.9px) {
.package-nav {
bottom: calc(1.25rem + env(safe-area-inset-bottom, 0px));
}

.package-nav > :deep(a kbd) {
display: none;
}

.package-page {
padding-bottom: calc(4.5rem + env(safe-area-inset-bottom, 0px));
}
}
</style>
Loading