refactor(ui): fetch results on submit instead of on type #1107
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| <script setup lang="ts"> | ||
| defineProps<{ | ||
| compact?: boolean | ||
| }>() | ||
|
|
||
| const emit = defineEmits<{ | ||
| (e: 'submit', searchQuery: string): void | ||
| (e: 'blur'): void | ||
| (e: 'focus'): void | ||
| }>() | ||
|
|
||
| const searchQuery = defineModel<string>({ | ||
| default: '', | ||
| }) | ||
|
MatteoGabriele marked this conversation as resolved.
|
||
|
|
||
| function handleSubmit() { | ||
| emit('submit', searchQuery.value) | ||
| } | ||
|
|
||
| function handleBlur() { | ||
| emit('blur') | ||
| } | ||
| function handleFocus() { | ||
| emit('focus') | ||
| } | ||
|
|
||
| // Expose focus method for parent components | ||
| const inputRef = useTemplateRef('inputRef') | ||
| function focus() { | ||
| inputRef.value?.focus() | ||
| } | ||
|
|
||
| defineExpose({ | ||
| focus, | ||
| }) | ||
| </script> | ||
|
|
||
| <template> | ||
| <search class="w-full @container"> | ||
| <form method="GET" action="/search" class="relative" @submit.prevent="handleSubmit"> | ||
| <label for="search-box" class="sr-only"> | ||
| {{ $t('search.label') }} | ||
|
ghostdevv marked this conversation as resolved.
|
||
| </label> | ||
|
|
||
| <div class="relative group"> | ||
| <div | ||
| class="absolute -inset-px rounded-lg bg-gradient-to-r from-fg/0 via-fg/5 to-fg/0 opacity-0 transition-opacity duration-500 blur-sm group-[.is-focused]:opacity-100" | ||
| /> | ||
|
|
||
| <div class="search-box relative flex items-center"> | ||
| <span | ||
| class="absolute text-fg-subtle font-mono pointer-events-none transition-colors duration-200 motion-reduce:transition-none [.group:hover:not(:focus-within)_&]:text-fg/80 group-focus-within:text-accent z-1" | ||
| :class="compact ? 'inset-is-3 text-sm' : 'inset-is-4 text-xl'" | ||
| > | ||
| / | ||
| </span> | ||
|
|
||
| <input | ||
| id="search-box" | ||
| ref="inputRef" | ||
| v-model.trim="searchQuery" | ||
| type="search" | ||
| name="q" | ||
| :placeholder="$t('search.placeholder')" | ||
|
ghostdevv marked this conversation as resolved.
|
||
| v-bind="noCorrect" | ||
| class="w-full bg-bg-subtle border border-border text-base font-mono text-fg placeholder:text-fg-subtle transition-[border-color,outline-color] duration-300 motion-reduce:transition-none hover:border-fg-subtle outline-2 outline-transparent focus:border-accent focus-visible:(outline-2 outline-accent/70)" | ||
| :class=" | ||
| compact ? 'ps-7 pe-3 py-1.5 rounded-md text-sm!' : 'ps-8 pe-24 h-14 py-4 rounded-xl' | ||
| " | ||
| @blur="handleBlur" | ||
| @focus="handleFocus" | ||
| /> | ||
|
|
||
| <button | ||
| type="submit" | ||
| class="absolute hidden @xs:block group inset-ie-2.5 font-mono text-sm transition-[background-color,transform] duration-200 active:scale-95" | ||
| :class=" | ||
| compact | ||
| ? 'px-1.5 py-0.5 @md:ps-4 @md:pe-4' | ||
| : 'rounded-md px-2.5 @md:ps-4 @md:pe-4 py-2 text-bg bg-fg/90 hover:bg-fg! group-focus-within:bg-fg/80' | ||
| " | ||
| > | ||
| <span | ||
| class="inline-block i-carbon:search align-middle w-4 h-4 @md:me-2" | ||
| aria-hidden="true" | ||
| ></span> | ||
| <span class="sr-only @md:not-sr-only"> | ||
| {{ $t('search.button') }} | ||
|
ghostdevv marked this conversation as resolved.
|
||
| </span> | ||
| </button> | ||
| </div> | ||
| </div> | ||
| </form> | ||
| </search> | ||
| </template> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the difference in nuxt between the
router.pushthat was happening before, and this?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, I think either option would work.
Previously, this component had no route handling, so I copy-pasted the function from the homepage, as they serve the same purpose. I didn't check whether it was navigateTo or router.push, since they essentially perform the same action. I believe navigateTo is a helper function that can also be used on the server side.