Skip to content

feat: make k8Secrets auth provider secret cache TTL configurable#2581

Merged
fseldow merged 4 commits into
notaryproject:v1-devfrom
ramasai1:make-expireson-configurable
Jun 24, 2026
Merged

feat: make k8Secrets auth provider secret cache TTL configurable#2581
fseldow merged 4 commits into
notaryproject:v1-devfrom
ramasai1:make-expireson-configurable

Conversation

@ramasai1

Copy link
Copy Markdown

Description

Make the cache TTL for k8Secrets provider configurable.

Which issue(s) does this PR resolve?

Fixes #2580

Type of change

  • New feature (non-breaking change which adds functionality)
  • Helm chart change (any edit/addition/update that is necessary for changes merged to the main branch)

Testing and verification

Unit tests.

Checklist

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post merge requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

Signed-off-by: Ramasai Venkatsitarambhaskar Tadepalli <ramasai.tadepalli@mongodb.com>
@ramasai1 ramasai1 force-pushed the make-expireson-configurable branch from d73e3b4 to b6c8568 Compare June 11, 2026 16:30
Comment thread pkg/common/oras/authprovider/k8secret_authprovider.go Outdated
@ramasai1 ramasai1 requested a review from fseldow June 12, 2026 13:32
Signed-off-by: Ramasai Venkatsitarambhaskar Tadepalli <ramasai.tadepalli@mongodb.com>
@ramasai1 ramasai1 force-pushed the make-expireson-configurable branch from 13e70b2 to 6128881 Compare June 12, 2026 13:33
Comment thread docs/design/K8s Secrets AuthProvider.md

@fseldow fseldow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small comment in doc, others lgtm
cc @susanshi for review or vote from maintainer

@fseldow fseldow enabled auto-merge (squash) June 24, 2026 04:07
@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (v1-dev@313fd08). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../common/oras/authprovider/k8secret_authprovider.go 60.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             v1-dev    #2581   +/-   ##
=========================================
  Coverage          ?   71.82%           
=========================================
  Files             ?      147           
  Lines             ?     7528           
  Branches          ?        0           
=========================================
  Hits              ?     5407           
  Misses            ?     1735           
  Partials          ?      386           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fseldow fseldow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fseldow fseldow disabled auto-merge June 24, 2026 04:54
@fseldow fseldow merged commit 84e9a7c into notaryproject:v1-dev Jun 24, 2026
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants