test: unskip snapshot reproducibility test#63307
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63307 +/- ##
==========================================
+ Coverage 90.04% 90.05% +0.01%
==========================================
Files 713 714 +1
Lines 225003 225247 +244
Branches 42536 42584 +48
==========================================
+ Hits 202606 202852 +246
- Misses 14177 14179 +2
+ Partials 8220 8216 -4 🚀 New features to boost your workflow:
|
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
This comment has been minimized.
This comment has been minimized.
sxa
left a comment
There was a problem hiding this comment.
The reproducibility test job hasn't been showing any problems, although it's still configured to build with gcc. Have you been seeing problems pre-14.6?
Either way I'm happy to have this test unskipped :-)
|
It was skipped in #62808 likely because there was a v8 bug that got triggered only on shared builds (this tends to be dependent on the shape the memory graph happen to be), but not on other Linux builds, which was likely fixed in the 14.6 upgrade (probably by https://chromium-review.googlesource.com/c/v8/v8/+/7666243) |
|
Landed in 61d66c3 |
See if the v8 14.6 upgrade has fixed it.
On a side note, debian will require reproducible builds in their packages https://lists.debian.org/debian-devel-announce/2026/05/msg00001.html