Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -739,7 +739,7 @@ jobs:
benchmark-data-dir-path: ""
# Set auto-push to false since GitHub API token is not given
auto-push: false
alert-threshold: '170%'
alert-threshold: '185%'
gh-pages-branch: "benchmark-results"
fail-on-alert: true
- name: Push benchmark result
Expand Down
291 changes: 145 additions & 146 deletions go.mod

Large diffs are not rendered by default.

644 changes: 320 additions & 324 deletions go.sum

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
type: containermetrics
type: container_metrics

status:
class: receiver
Expand Down
13 changes: 3 additions & 10 deletions internal/collector/otelcol.tmpl
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
receivers:
{{- if ne .Receivers.ContainerMetrics nil }}
containermetrics:
container_metrics:
{{- if .Receivers.ContainerMetrics.CollectionInterval }}
collection_interval: {{ .Receivers.ContainerMetrics.CollectionInterval }}
{{- end}}
{{- end }}

{{- if ne .Receivers.HostMetrics nil }}
hostmetrics:
host_metrics:
{{- if .Receivers.HostMetrics.CollectionInterval }}
collection_interval: {{ .Receivers.HostMetrics.CollectionInterval }}
{{- end}}
Expand Down Expand Up @@ -275,14 +275,7 @@ service:
metrics/{{$pipelineName}}:
receivers:
{{- range $receiver := $pipeline.Receivers }}
{{- if eq $receiver "host_metrics" }}
{{- if ne $.Receivers.ContainerMetrics nil }}
- containermetrics
{{- end }}
{{- if ne $.Receivers.HostMetrics nil }}
- hostmetrics
{{- end }}
{{- else if eq $receiver "nginx_metrics" }}
{{- if eq $receiver "nginx_metrics" }}
{{- range $.Receivers.NginxReceivers }}
{{- if gt (len $.Receivers.NginxReceivers) 1 }}
- nginx/{{- .InstanceID -}}
Expand Down
2 changes: 1 addition & 1 deletion internal/collector/settings_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ func TestTemplateWrite(t *testing.T) {
cfg.Collector.Pipelines.Metrics = make(map[string]*config.Pipeline)
cfg.Collector.Pipelines.Metrics["default"] = &config.Pipeline{
Receivers: []string{
"hostmetrics", "containermetrics",
"host_metrics", "container_metrics",
"otlp/default", "nginx", "nginxplus/456", "nginxplus/789",
},
Processors: []string{"resource/default", "batch/default"},
Expand Down
4 changes: 2 additions & 2 deletions internal/collector/testdata/merge_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ processors:
key: resource.id
value: f16dedd7-929f-3642-b823-4ac8d295cc23
receivers:
hostmetrics:
host_metrics:
collection_interval: 1m0s
initial_delay: 1s
scrapers:
Expand All @@ -57,7 +57,7 @@ service:
- batch/default_metrics
- resource/default
receivers:
- hostmetrics
- host_metrics
metrics/prometheus-example-pipeline:
exporters:
- prometheus
Expand Down
4 changes: 2 additions & 2 deletions internal/collector/testdata/otel_config.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
receivers:
hostmetrics:
host_metrics:
collection_interval: 1m0s
initial_delay: 1s
scrapers:
Expand Down Expand Up @@ -56,7 +56,7 @@ service:
pipelines:
metrics/default:
receivers:
- hostmetrics
- host_metrics
processors:
- batch/default_metrics
- resource/default
Expand Down
17 changes: 16 additions & 1 deletion internal/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -214,9 +214,20 @@ func addDefaultPipelines(collector *Collector) {
if collector.Pipelines.Metrics == nil {
collector.Pipelines.Metrics = make(map[string]*Pipeline)
}

isContainer, err := host.NewInfo().IsContainer()
if err != nil {
slog.Debug("No container information found", "error", err)
}
receivers := []string{"host_metrics", "nginx_metrics"}
if isContainer {
receivers = append(receivers, "container_metrics")
}

// add check if container and nginx plus or oss
if _, ok := collector.Pipelines.Metrics[DefaultPipeline]; !ok {
collector.Pipelines.Metrics[DefaultPipeline] = &Pipeline{
Receivers: []string{"host_metrics", "nginx_metrics"},
Receivers: receivers,
Processors: []string{"batch/default_metrics"},
Exporters: []string{"otlp_grpc/default"},
}
Expand Down Expand Up @@ -1248,6 +1259,10 @@ func resolvePipelines() Pipelines {
}
}

if metricsPipelines["default"] != nil && slices.Contains(metricsPipelines["default"].Receivers, "host_metrics") {
metricsPipelines["default"].Receivers = append(metricsPipelines["default"].Receivers, "container_metrics")
}

var logsPipelines map[string]*Pipeline

if viperInstance.IsSet(CollectorLogsPipelinesKey) {
Expand Down
1 change: 1 addition & 0 deletions internal/config/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ func TestResolveConfig(t *testing.T) {
headers := actual.Collector.Extensions.HeadersSetter.Headers
return headers[i].Key < headers[j].Key
})

assert.Equal(t, createConfig(), actual)
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
receivers:
containermetrics:
container_metrics:
collection_interval: 1s
hostmetrics:
host_metrics:
collection_interval: 1m0s
initial_delay: 1s
scrapers:
Expand Down Expand Up @@ -123,8 +123,8 @@ service:
pipelines:
metrics/default:
receivers:
- hostmetrics
- containermetrics
- host_metrics
- container_metrics
- otlp/default
- nginx
- nginxplus/456
Expand Down
Loading