Skip to content

revert: timezone conversion intended for meta fields, accidentally broke datetime columns #2583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samuelx12 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

revert: timezone conversion intended for meta fields, accidentally broke datetime columns #2583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b8f4c3
Revert "fix: Adjust date formatting"
samuelx12 May 7, 2026
9d0f26a
Revert "Enhancement: Apply user's timezone to meta fields (alternativ…
samuelx12 May 7, 2026
5529364
Revert "Enhancement: Apply user's timezone to meta fields"
samuelx12 May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/modules/main/partials/ColumnInfoPopover.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,7 @@ export default {
},
methods: {
relativeDateTime(v) {
const value = moment.utc(v).local()
return value.format('L') === moment().format('L') ? t('tables', 'Today') + ' ' + value.format('LT') : value.format('LLLL')
return moment(v).format('L') === moment().format('L') ? t('tables', 'Today') + ' ' + moment(v).format('LT') : moment(v).format('LLLL')
},
},
}
Expand Down
2 changes: 1 addition & 1 deletion src/shared/components/ncTable/mixins/columnsTypes/datetime.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export default class DatetimeColumn extends AbstractDatetimeColumn {
}

formatValue(value) {
return Moment.utc(value, 'YYYY-MM-DD HH:mm:ss').local().format('lll')
return Moment(value, 'YYYY-MM-DD HH:mm:ss').format('lll')
}

sort(mode, nextSorts) {
Expand Down
2 changes: 1 addition & 1 deletion src/shared/components/ncTable/mixins/columnsTypes/datetimeDate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export default class DatetimeDateColumn extends AbstractDatetimeColumn {
}

formatValue(value) {
return Moment.utc(value, 'YYYY-MM-DD HH:mm:ss').local().format('ll')
return Moment(value, 'YYYY-MM-DD HH:mm:ss').format('ll')
}

sort(mode, nextSorts) {
Expand Down
2 changes: 1 addition & 1 deletion src/shared/components/ncTable/mixins/columnsTypes/datetimeTime.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export default class DatetimeTimeColumn extends AbstractDatetimeColumn {
}

formatValue(value) {
return Moment.utc(value, 'HH:mm:ss').local().format('LT')
return Moment(value, 'HH:mm:ss').format('LT')
}

sort(mode, nextSorts) {
Expand Down
5 changes: 1 addition & 4 deletions src/shared/components/ncTable/partials/TableCellDateTime.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,10 +171,7 @@ export default {
newValue = 'none'
} else {
const format = this.getDateFormat()
const editDateTimeMoment = Moment(this.editDateTimeValue)
newValue = this.column.type === 'datetime-date'
? editDateTimeMoment.format(format)
: editDateTimeMoment.utc().format(format)
newValue = Moment(this.editDateTimeValue).format(format)
}

if (newValue === this.value) {
Expand Down
2 changes: 1 addition & 1 deletion src/shared/components/ncTable/partials/rowTypePartials/DatetimeForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export default {
} else if (!v) {
this.$emit('update:value', this.isMandatoryField ? null : 'none')
} else {
this.$emit('update:value', Moment(v).utc().format('YYYY-MM-DD HH:mm'))
this.$emit('update:value', Moment(v).format('YYYY-MM-DD HH:mm'))
}
},
},
Expand Down
2 changes: 1 addition & 1 deletion src/shared/components/ncTable/partials/rowTypePartials/DatetimeTimeForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export default {
if (v === 'none') {
this.$emit('update:value', v)
} else if (v) {
this.$emit('update:value', Moment(v).utc().format('HH:mm'))
this.$emit('update:value', Moment(v).format('HH:mm'))
}
},
},
Expand Down