Skip to content

fix: handle first option select #2582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luka-nextcloud wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

fix: handle first option select #2582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Service/ColumnTypes/SelectionBusiness.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public function parseValue($value, Column $column): string {

foreach ($column->getSelectionOptionsArray() as $option) {
if ($option['id'] === $intValue) {
return json_encode($option['id']);
return json_encode((string)$option['id']);
}
}

Expand Down
6 changes: 3 additions & 3 deletions tests/unit/Service/ColumnTypes/SelectionBusinessTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ public function setUp(): void {

public function parseValueProvider(): array {
return [
'valid integer value' => [2, '2'],
'valid string value' => ['2', '2'],
'valid string value for numeric option' => ['4', '4'],
'valid integer value' => [2, '"2"'],
'valid string value' => ['2', '"2"'],
'valid string value for numeric option' => ['4', '"4"'],
'invalid value' => [5, ''],
'null value' => [null, ''],
'empty string' => ['', ''],
Expand Down
Loading