feat: add URL normalization for Figshare downloads Implement a new f…#334
Open
chardiwall wants to merge 7 commits into
Open
feat: add URL normalization for Figshare downloads Implement a new f…#334chardiwall wants to merge 7 commits into
chardiwall wants to merge 7 commits into
Conversation
…nction to normalize Figshare download URLs and add a corresponding test to ensure functionality.
Co-authored-by: Cursor <cursoragent@cursor.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #334 +/- ##
===========================================
- Coverage 76.48% 73.70% -2.78%
===========================================
Files 48 49 +1
Lines 2994 3054 +60
===========================================
- Hits 2290 2251 -39
- Misses 704 803 +99 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
- Added CODECOV_TOKEN to CI configuration for better coverage reporting. - Introduced a filter to suppress deprecation warnings related to pkg_resources in pyproject.toml. - Removed the deprecated _normalize_download_url function and replaced its usage in download_url. - Enhanced plot_animation function to manage figure closing and garbage collection. - Updated drop_pixel function to ensure float conversion for max_occur calculation. - Deleted obsolete test file for download utilities.
modified: .github/workflows/ci-pipeline.yml modified: test/conftest.py new file: test/test_data/dsec/thun_00_a/disparity_timestamps/thun_00_a_disparity_timestamps.txt new file: test/test_data/dsec/thun_00_a/image_exposure_timestamps_left/thun_00_a_image_exposure_timestamps_left.txt new file: test/test_data/dsec/thun_00_a/image_timestamps/thun_00_a_image_timestamps.txt new file: test/test_data/dsec/thun_00_a/optical_flow_forward_event/000000.png new file: test/test_data/dsec/thun_00_a/optical_flow_forward_timestamps/thun_00_a_optical_flow_forward_timestamps.txt modified: test/test_dsec.py chore: update CI pipeline and enhance DSEC testing - Upgraded actions/checkout from v4 to v5 in CI configuration. - Updated astral-sh/setup-uv from v6 to v8 for improved setup. - Added new pytest fixtures to facilitate DSEC testing without network downloads. - Refactored DSEC test cases to utilize the new fixtures and ensure proper data handling. - Introduced test data files for DSEC optical flow and timestamps to support testing.
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
|
@chardiwall Thank you for this PR, I'm going to look over it in detail shortly. One thing I noticed was that you also updated the CI actions. That's indeed overdue, but I'm going to peg those to specific commits (in a dedicated PR), so I was wondering if you could please update the PR to revert those changes? Thank you! |
Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
@cantordust Thank you for following up. I have rolled back the changes on the CI actions. The current version only solves the issue with downloading DVS datasets. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Figshare downloads blocked by AWS WAF (#330)
Figshare's
https://figshare.com/ndownloader/files/...URLs are blocked by AWS WAF for programmatic clients, causing 0-byte responses and MD5 check failures for datasets such as DVSGesture and CIFAR10DVS.Fix: Rewrite Figshare download URLs inline in
download_url()from:To
##Closes
Fixes #330
Fixes #329