Fix NSS bundling for Windows clients, do not abort upsmon if SSL was not required (and we failed to set it up)#3429
Open
jimklimov wants to merge 2 commits intonetworkupstools:masterfrom
Open
Conversation
…etworkupstools#3420] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…i_init() but did not require SSL in the first place [networkupstools#3420] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added
packaging
Windows
upsmon
impacts-release-2.8.5
jimklimov
changed the title
upsmon if SSL was not required (and we failed to set it up)upsmon if SSL was not required (and we failed to set it up)
|
A ZIP file with standard source tarball and another tarball with pre-built docs for commit 7b3e6c8 is temporarily available: NUT-tarballs-PR-3429.zip. |
|
❌ Build nut 2.8.5.4673-master failed (commit a7764ea2b9 by @jimklimov) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #3420
nss3.dllbut not referenced from it in a way visible toobjdump,lddand similar tools. Hopefullystrings | grepwould fare better to catch such cases.NoDBmode in NSS builds failed if the library could not load (due to trouble above). Currentlyupsmonaborted the start-up if it could not initialize SSL (also in older releases), but now this happened with runs that did not require the SSL at all.return -1in some failure cases earlier too, so this is not a newly introduced change of behavior. Just there is now more abilities and more error-checking inside.