[infrastructure] Deprecate legacy Dex and Zitadel getting-started scripts - #6952
Conversation
📝 WalkthroughWalkthroughLegacy Dex and Zitadel getting-started scripts were replaced with retirement notices that exit unsuccessfully. The infrastructure workflow now verifies their exit status, stdout, stderr messages, version-removal text, and documentation links. ChangesLegacy getting-started script retirement
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/test-infrastructure-files.yml (1)
252-284: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick winJob runs with default (broad)
GITHUB_TOKENpermissions.Static analysis flags this job for lacking an explicit
permissions:block, so it inherits the repository/workflow default rather than a scoped-down set. Since this job only checks out code and runs local scripts, it needs no write access.🔧 Suggested fix
test-legacy-getting-started-scripts: runs-on: ubuntu-latest + permissions: + contents: read steps:🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/test-infrastructure-files.yml around lines 252 - 284, Add an explicit job-level permissions block to test-legacy-getting-started-scripts, granting only the minimum access required for checkout and local script execution, with no write permissions. Keep the existing checkout and retirement-notice verification steps unchanged.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/test-infrastructure-files.yml:
- Around line 252-284: Add an explicit job-level permissions block to
test-legacy-getting-started-scripts, granting only the minimum access required
for checkout and local script execution, with no write permissions. Keep the
existing checkout and retirement-notice verification steps unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 2f50ca2a-1969-47fc-a879-ebcb4c5dfbe9
📒 Files selected for processing (3)
.github/workflows/test-infrastructure-files.ymlinfrastructure_files/getting-started-with-dex.shinfrastructure_files/getting-started-with-zitadel.sh
Release artifactsBuilt for PR head
GHCR images (amd64)
This comment is updated by the Release workflow. Artifact links expire according to the workflow retention policy. |
3 participants
Describe your changes
Retire the legacy Dex and Zitadel installation scripts by replacing their implementations with compatibility notices that:
getting-started.shand the self-hosting quickstart.Replace the legacy Zitadel provisioning workflow with CI checks that verify both scripts fail, write their notices to stderr, and include the expected documentation links and removal version.
Issue ticket number and link
No single issue tracks this deprecation.
Related to:
SELF HOST not success, request /api/users get 502 Bad Gateway #2046, and Installation script fails on Alpine due to date syntax #1966.
Stack
Standalone PR based on
main.Checklist
Documentation
Select exactly one:
Docs PR URL (required if "docs added" is checked)
Paste the PR link from https://github.com/netbirdio/docs here:
N/A
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by CodeRabbit