[management] chores: update dex version#6124
Conversation
📝 WalkthroughWalkthroughGo module replace directives for ChangesDex Dependency Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Around line 344-346: Update the PR description to explicitly state that the
dex replacement (github.com/dexidp/dex => github.com/netbirdio/dex at commit
a1d4a044de6e / v0.244.1-0.20260512090214-a1d4a044de6e and
github.com/dexidp/dex/api/v2 => github.com/netbirdio/dex/api/v2
v2.0.0-20260512090214-a1d4a044de6e) includes a fix for SQLite text password
groups handling; then run and confirm tests in the netbird codebase that
exercise authentication with SQLite-backed dex (unit tests, integration tests,
and a manual auth flow using SQLite DB) and add a short confirmation note in the
PR describing which tests were run and their results.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 6df14670-f445-4a78-8c3e-9383fdfd6cab
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
| replace github.com/dexidp/dex => github.com/netbirdio/dex v0.244.1-0.20260512090214-a1d4a044de6e | ||
|
|
||
| replace github.com/dexidp/dex/api/v2 => github.com/netbirdio/dex/api/v2 v2.0.0-20260415145816-a0c6b40ff9f2 | ||
| replace github.com/dexidp/dex/api/v2 => github.com/netbirdio/dex/api/v2 v2.0.0-20260512090214-a1d4a044de6e |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Verify the dex commit exists and check what changes are included
# Check if the commit exists in netbirdio/dex
echo "=== Checking if commit a1d4a044de6e exists in netbirdio/dex ==="
gh api repos/netbirdio/dex/commits/a1d4a044de6e --jq '.sha, .commit.message, .commit.author.date' 2>&1 || echo "Commit not found or API error"
echo ""
echo "=== Comparing with previous commit a0c6b40ff9f2 ==="
gh api repos/netbirdio/dex/compare/a0c6b40ff9f2...a1d4a044de6e --jq '.commits[] | {sha: .sha, message: .commit.message, date: .commit.author.date}' 2>&1 || echo "Comparison failed or API error"Repository: netbirdio/netbird
Length of output: 423
Update PR description and confirm testing for SQLite password groups fix.
The updated dex commit fixes SQLite text password groups handling. Please update the PR description to document this fix and confirm it has been tested with the netbird codebase.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@go.mod` around lines 344 - 346, Update the PR description to explicitly state
that the dex replacement (github.com/dexidp/dex => github.com/netbirdio/dex at
commit a1d4a044de6e / v0.244.1-0.20260512090214-a1d4a044de6e and
github.com/dexidp/dex/api/v2 => github.com/netbirdio/dex/api/v2
v2.0.0-20260512090214-a1d4a044de6e) includes a fix for SQLite text password
groups handling; then run and confirm tests in the netbird codebase that
exercise authentication with SQLite-backed dex (unit tests, integration tests,
and a manual auth flow using SQLite DB) and add a short confirmation note in the
PR describing which tests were run and their results.
Release artifactsBuilt for PR head
GHCR images (amd64)
This comment is updated by the Release workflow. Artifact links expire according to the workflow retention policy. |
|
mlsmaycon
changed the title
2 participants
Describe your changes
With the MFA PR #5804 there was an update on the Dex package which was causing the server to fail while trying to load the idp
passwordtableThe merged PR netbirdio/dex#5 on our Dex fork fixes this issue by introducing an extra migration and some validation guardrails to make sure there aren't issues trying to parse this field
This pull request updates the Dex package to a version where this issue is no longer present
Issue ticket number and link
Stack
Checklist
Documentation
Select exactly one:
Docs PR URL (required if "docs added" is checked)
Paste the PR link from https://github.com/netbirdio/docs here:
https://github.com/netbirdio/docs/pull/__
Summary by CodeRabbit