Clarify auto-deletion policy for empty folders and links#1261
Clarify auto-deletion policy for empty folders and links#1261geoffreyweal wants to merge 1 commit into
Conversation
Added details about the removal of empty folders and clarified that only child folders will be deleted. Updated the note on symbolic links and their treatment during the autocleaning process. Signed-off-by: Geoffrey Weal <geoffrey.weal@gmail.com>
|
Test deployment successful!! (2026-05-08T01:10:45Z) See all deployed demo sites |
There was a problem hiding this comment.
Code Review
Ahoy! This patch updates the logbook on how we scuttle empty folders in the 'nobackup' depths. It clarifies that only the wee child folders get the plank, while the parents and broken ghost-links stay moored. The reviewer, sharp as a cutlass, spotted some murky phrasing about those links and a bit of sloppy spelling regarding 'auto-deletion' that needs fixin' to keep the records consistent. Get it sorted, ye landlubber!
|
|
||
| **Only child folders will be deleted**. Any parent folders that are empty after this process will not be deleted. | ||
|
|
||
| Symbolic links will not be removed, if at deletion time they are broken. These entities typically take up no disk space apart from a small amount of metadata, but still count towards the project's inode (file count) quota. |
There was a problem hiding this comment.
Blimey, this sentence is as murky as a barrel o' bilge water. By addin' that comma, ye've made it sound like broken links are the only ones spared from the locker. If ye mean to say they're all safe even if they're broken, then speak with a clear tongue!
| Symbolic links will not be removed, if at deletion time they are broken. These entities typically take up no disk space apart from a small amount of metadata, but still count towards the project's inode (file count) quota. | |
| Symbolic links will not be removed, even if they are broken at deletion time. These entities typically take up no disk space apart from a small amount of metadata, but still count towards the project's inode (file count) quota. |
| Objects other than files, such as directories and symbolic links, are not yet deleted under this policy (we will be reviewing the directory deletion policy in the next few months), even if at deletion time they are empty, broken, or otherwise redundant. These entities typically take up no disk space apart from a small amount of metadata, but still count towards the project's inode (file count) quota. | ||
| ### Empty folders will be removed | ||
|
|
||
| If a folder has been emptied of files from the autodeletion method, it too will be removed. **Only empty folders will be removed**. A folder that still contains files after the autocleaning process will not be removed. |
There was a problem hiding this comment.
Avast! Ye seem to be havin' trouble steerin' the ship straight with yer spellin'. Is it 'auto-deletion' or 'autodeletion'? The title says one thing, and line 27 agrees, yet here ye are driftin' off course. Consistency is the anchor of a good logbook, ye scurvy dog.
| If a folder has been emptied of files from the autodeletion method, it too will be removed. **Only empty folders will be removed**. A folder that still contains files after the autocleaning process will not be removed. | |
| If a folder has been emptied of files from the auto-deletion method, it too will be removed. **Only empty folders will be removed**. A folder that still contains files after the autocleaning process will not be removed. |
Added details about the removal of empty folders and clarified that only child folders will be deleted. Updated the note on symbolic links and their treatment during the autocleaning process.