fix: prune Gaussians when initialized above cap_max in MCMC strategy#939
Open
jashshah999 wants to merge 1 commit into
Open
fix: prune Gaussians when initialized above cap_max in MCMC strategy#939jashshah999 wants to merge 1 commit into
jashshah999 wants to merge 1 commit into
Conversation
When initializing from SfM with more Gaussians than cap_max, MCMC had no mechanism to prune down. The relocate step only replaces dead Gaussians, and _add_new_gs correctly adds zero when over cap, but nothing removed the excess. Add _prune_to_cap() that removes the lowest-opacity Gaussians when the count exceeds cap_max. Runs before relocate in the refine step. Fixes nerfstudio-project#516.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When initializing from SfM with more Gaussians than
cap_max, the MCMC strategy has no way to prune down._relocate_gsonly replaces dead Gaussians (doesn't reduce count), and_add_new_gscorrectly adds zero when over cap, but nothing removes the excess.Fix
Add
_prune_to_cap()that removes the lowest-opacity Gaussians when count exceedscap_max. Runs before relocate in the refine step so the subsequent relocate and add steps operate within the cap.Uses the existing
remove()utility fromops.py.Fixes #516.