fix: niks3の参照先を上流に戻す#1300
Merged
Merged
Conversation
私が懸念して伝えた内容が、 Mic92/niks3#426 で解決が試みられたので、 まず上流の解決策である、 こちらを試してみる。
ncaq
added
Type: Bug
nvd diff: seminar (base: master)Version changes
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
niks3の参照先をフォークgithub:ncaq/niks3/dup-multipartから上流github:Mic92/niks3に戻す変更です。
フォークのdup-multipartブランチが回避策として対処していた懸念は、上流の Mic92/niks3#426 で正式に解決されています。flake.lockに固定された新リビジョンaa930845はそのPRのマージコミットそのものであり、フォークの意図する変更は上流に取り込まれています。クライアント側のCLIインターフェースに変更はなく、本リポジトリの利用箇所(niks3-push-ncaqや各NixOSモジュール)も設定変更不要です。
リグレッションリスクは低く、依存を上流に一本化する妥当な変更と評価します。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
私が懸念して伝えた内容が、
Mic92/niks3#426
で解決が試みられたので、
まず上流の解決策である、
こちらを試してみる。