Drop articles before renameable domain words#51
Merged
Conversation
Apply SUBSTRATE-CONTRACT.md rule 1: UI strings and seed data must not couple articles to renameable domain nouns (Shop, ItemTag, Shopkeeper), so the agent's rename pipeline produces grammatical output for any target word. Mirrors nativeapptemplate/NativeAppTemplate-iOS#77. Of the 7 iOS UI string changes, 3 have Android equivalents in strings.xml; the other 4 are toast/error strings that don't exist on Android. The seed description fixtures (shop.json, shops.json) and the demo test that mirrors them are updated to match. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SUBSTRATE-CONTRACT.mdrule 1: UI strings must not couple articles to renameable domain nouns (Shop,ItemTag,Shopkeeper), so the agent's rename pipeline produces grammatical output for any target word (e.g."Swipe an item tag…"→"Swipe an patient…"afterItemTag → Patient).app/src/main/res/values/strings.xml; the other 4 are toast/error strings (shopDeletedError,itemTagDeletedError,itemTagCompletedError,itemTagIdledError) that don't exist on Android, so they're skipped.ShopAdapterTest.swift) maps to the seed JSON inapp/src/main/assets/{shop,shops}.jsonplus the matchingDemoShopRepositoryTestassertions — all four"This is a Shop1"-style strings updated to"This is Shop1"so demo deserialization tests stay green.shop_detail_instructionbecomes"Swipe to change item tag status."Test plan
./gradlew testDebugUnitTest --tests "com.nativeapptemplate.nativeapptemplatefree.demo.shop.DemoShopRepositoryTest"— passes./gradlew spotlessCheck lintDebug— clean🤖 Generated with Claude Code