Skip to content

fix: ARenderer TypeError when href is undefined #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsamr merged 2 commits into from
Apr 14, 2026
Merged

fix: ARenderer TypeError when href is undefined #32

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c6f82a
fix: ARenderer TypeError when href undefined
arieloO Mar 27, 2026
ed42508
test: add regression test for anchor without href when baseUrl is set
arieloO Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/render/src/renderers/ARenderer.tsx
View file
Open in desktop
Comment thread
jsamr marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,9 @@ function useAnchorOnLinkPress(
const { baseTarget } = useDocumentMetadata();
const shouldHandleLinkPress =
tnode.tagName === 'a' &&
typeof normalizedHref === 'string' &&
typeof href === 'string' &&
href.length > 0 &&
typeof normalizedHref === 'string' &&
typeof onPress === 'function';
return shouldHandleLinkPress
? (e: GestureResponderEvent) =>
Expand Down
Loading