Remove dead and deprecated code. - #2190
Open
brendan-nasa wants to merge 7 commits into
Open
Conversation
This flag was used to differentiate between draft C++11 (c++0x) and standard C++11 compiler support. Neither of which is needed anymore because Trick's baseline c++ version is c++17.
|
coverage: 56.777% (+0.02%) from 56.76% — remove-dead-code into master |
sharmeye
reviewed
Aug 21, 2026
| TRICK_SYSTEM_CXXFLAGS += -fcolor-diagnostics | ||
| else | ||
| GCC_MAJOR := $(shell $(TRICK_CC) -dumpversion | cut -f1 -d.) | ||
| GCC_MINOR := $(shell $(TRICK_CC) -dumpversion | cut -f2 -d.) |
Contributor
There was a problem hiding this comment.
are we sure we don't want to check the minor version, juuuuuust in case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
throw()->noexcept. Replace emptythrowexpressions withnoexcept. Destructors are implicitlynoexcept__GNUC__is defined for both clang and gcc. Removed those checks.Elif()which we had defined asElIf(). Wasn't caught because we usedvirtualinstead ofoverride.