Call deleteInstance before deleting oldType

[stanbot8]

AllocInfo::resize destroys oldType before invoking deleteInstance.

Call deleteInstance before deleting oldType.

[brendan-nasa]

Thanks for the bug report (and fix)! In the interest of investigating further, did you encounter any crashes/run time errors that you traced back to these few lines?

[coveralls]

coverage: 56.671%. remained the same — stanbot8:draft/allocinfo-lifetime-order into nasa:master

[stanbot8]

Hi Brendan, I was actually investigating a separate memory issue across my project's dependencies. I wrote a script that scans for suspicious patterns and this showed up alongside six other candidates. One of the other candidates turned out to be the culprit, but this looked worth submitting separately. I believe most Trick users won't encounter this issue, but the DataTypes test was updated last year so somebody might still be maintaining or using it.