Skip to content

Fix dialogs close#4707

Merged
Janpot merged 3 commits into
mui:masterfrom
Janpot:dialogs-close
Feb 27, 2025
Merged

Fix dialogs close#4707
Janpot merged 3 commits into
mui:masterfrom
Janpot:dialogs-close

Conversation

@Janpot

@Janpot Janpot commented Feb 27, 2025

Copy link
Copy Markdown
Member

Stabilize the context value. Event handlers are holding references to it and are operating on outdated state. Eventually we should implement it like #4628 but in the meantime this should work.

Closes #4706

@mui-bot

mui-bot commented Feb 27, 2025

Copy link
Copy Markdown

Netlify deploy preview

https://deploy-preview-4707--mui-toolpad-docs.netlify.app/

Generated by 🚫 dangerJS against 132e6d8

@Janpot Janpot added the internal Behind-the-scenes enhancement. Formerly called “core”. label Feb 27, 2025
@Janpot
Janpot marked this pull request as ready for review February 27, 2025 10:18
@Janpot
Janpot requested a review from bharatkashyap February 27, 2025 10:24

@bharatkashyap bharatkashyap left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Janpot
Janpot merged commit e844d6e into mui:master Feb 27, 2025
@Janpot
Janpot deleted the dialogs-close branch February 27, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Behind-the-scenes enhancement. Formerly called “core”.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

useDialogs close function not working as expected

3 participants