added the option for CPS and FK green's tensors to be in dispacement#338
Open
rwalkerlewis wants to merge 5 commits into
Open
added the option for CPS and FK green's tensors to be in dispacement#338rwalkerlewis wants to merge 5 commits into
rwalkerlewis wants to merge 5 commits into
Conversation
The CI was failing because the 'tables' package (PyTables) requires HDF5 development headers to build from source. Added libhdf5-dev and pkg-config to the system dependencies installation step. Co-authored-by: langleyreview <langleyreview@gmail.com>
The CI was using Python 3.14 (very new) which may cause compatibility issues with some packages. Pinning to Python 3.11 which is a stable version that should work well with all dependencies. Co-authored-by: langleyreview <langleyreview@gmail.com>
Ci test failures
Jinyin-Hu
reviewed
May 4, 2026
Jinyin-Hu
left a comment
Jinyin-Hu
left a comment
Member
There was a problem hiding this comment.
Hi Robert,
Thanks for the modifications. Sorry for being late to have a look at this fix. I'm gaining experiences with github.
Given CPS and FK output velocity by default, It seems the fix should be:
if 'type:velocity' not in self.tags and 'type:displacement' not in self.tags:
self.tags += ['type:velocity']
In the current modifications, I found it is 'or' to connect two conditions. This also applies for FK, and also the current version of Specfem3D.
if so, all them need to change from 'or' to 'and'.
Many thanks,
Jinyin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick fix to address issue #336