Conversation
Comment on lines
+16
to
+17
| mmc0 = &sdhc_1; // eMMC 固化为 /dev/mmcblk0 | ||
| mmc1 = &sdhc_2; // SD 卡 固化为 /dev/mmcblk1 |
There was a problem hiding this comment.
Try English in later revisions but we would leave it be for now.
Comment on lines
+40
to
+41
| regulator-always-on; /* lmdpdg 生成的 panel 驱动不读 vsp/vsn-supply */ | ||
| regulator-boot-on; /* 必须 always-on，否则 fixed regulator 启动时被拉低，屏黑 */ |
There was a problem hiding this comment.
It's possible to add vsp/vsn/*-supply to lmdpdg configs.
Comment on lines
+50
to
+51
| regulator-always-on; | ||
| regulator-boot-on; |
Comment on lines
+54
to
+60
| /* 预留 lk1st splash framebuffer 不被内核踩踏 */ | ||
| reserved-memory { | ||
| cont-splash@83200000 { | ||
| reg = <0 0x83200000 0 0x800000>; | ||
| no-map; | ||
| }; | ||
| }; |
There was a problem hiding this comment.
Not sure why you need this when you are using drm panel driver instead of simpledrm.
| monitored-battery = <&battery>; | ||
| qcom,fast-charge-safe-current = <900000>; /* 0.9 A 安全限流 */ | ||
| qcom,fast-charge-safe-voltage = <4200000>; /* PM8916 LBC 浮充上限 4.2V */ | ||
| }; No newline at end of file |
There was a problem hiding this comment.
Try to add EOL here.
The current sink supports 5 mA through 40 mA in 5 mA steps. Document the generic drive-strength values accepted by both PMIC MPP drivers.
PIN_CONFIG_DRIVE_STRENGTH is expressed in mA, but the SPMI MPP driver wrote that value directly to the zero-based three-bit current register. Convert 5-40 mA to and from the hardware encoding and reject unsupported values.
Describe the stock PM8916 MPP2 current-sink connection as a gpio-led at the original 5 mA setting. The active-high GPIO level controls the MPP mode enable bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.