feat(no-export): disallow exports in files containing tests - #493
Open
unlikelyzero wants to merge 1 commit into
Open
feat(no-export): disallow exports in files containing tests#493unlikelyzero wants to merge 1 commit into
unlikelyzero wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
no-exportrule, ported fromjest/no-export.Playwright collects spec files by running them, not by importing anything they export, so an
exportin a spec file has no effect on the test run. It usually means a helper that belongs in a shared module, or a leftover from a file that used to be something else. It's also a subtle footgun: importing a spec file to reuse an export registers its tests a second time.The rule only fires in files that contain at least one
testortest.describecall, so fixture and helper modules are unaffected. ESM exports (export const,export default,export *,export { … },export type), TypeScript'sexport =, and CommonJSmodule.exports/module.exports.fooare all covered. A locally declaredmodulevariable is not treated as CommonJS.Not enabled in the recommended config, matching
eslint-plugin-jest.