Skip to content

Fixing the encoding of the password for special characters #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amadejzr wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixing the encoding of the password for special characters #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6543d27
⬆️ (pubspec.yaml): upgrade http dependency to version 1.2.2 to stay u…
amadejzr Sep 23, 2024
84fbb0c
Encoding fix
amadejzr Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/src/messages/common/utils.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ Uint8List encodeUtf16le(String s) => Uint8List.fromList(
);

Uint8List createLMHashedPasswordV1(String password) {
var oemPassword = ascii.encode(password.toUpperCase());
var oemPassword = utf8.encode(password.toUpperCase());
var length = math.min(oemPassword.length, 14);
var keyBytes = List<int>.filled(14, 0);
_arrayCopy(oemPassword, 0, keyBytes, 0, length);
Expand Down
4 changes: 2 additions & 2 deletions pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
name: ntlm
description: Library for making HTTP requests that require NTLM authentication
version: 2.0.1
version: 2.0.3
homepage: https://github.com/mrbbot/ntlm

environment:
sdk: '>=2.12.0 <3.0.0'

dependencies:
http: ^0.13.1
http: ^1.2.2
pointycastle: ^3.0.1
fixnum: ^1.0.0

Expand Down