Add Enterprise Add-on API

[chrstinalin]

Fixes mozilla/addons#14851

Description

Adds API support for enterprise channel work.

Testing

• V3 and V4 APIs do not support enterprise uploads.
• Does not show enterprise by default anywhere (following unlisted behaviour)
• Only authors & those with unlisted permissions can access the APIs.

1. Upload

/api/v5/addons/upload/

• POST can take and create an enterprise upload.
• GET should include any previously uploaded enterprise uploads.

/api/v5/addons/upload/<string:uuid>/

• GET shows details about an enterprise upload. Should show the ADMIN_INSTALL_ONLY_REQUIRED error when the setting is missing.

Screenshots

2. Add-on

/api/v5/addons/addon/

• POST can take an enterprise upload and create a new add-on.

3. Version

/api/v5/addons/addon/(int:addon_id|string:addon_slug|string:addon_guid)/versions/

• POST Allows submitting an enterprise upload as a version to an existing add-on.
• GET does not show enterprise versions by default. Can filter to show via enterprise_only.

/api/v5/addons/addon/(int:addon_id|string:addon_slug|string:addon_guid)/versions/(int:id|string:version_number)/

• GET can retrieve an enterprise version.

Checklist

• Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
• Successfully verified the change locally.
• The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.

[nothingrandom]

Feel uncomfortable being the only one looking at this, @eviljeff or @diox - are you happy to take a look also?

[eviljeff]

Looks fine, just looking for some clarification before approving.

[eviljeff]

all_with_unlisted is actually "all" - i.e. including listed, unlisted, and enterprise.

Two questions here:

• do we want all_with_unlisted to include enterprise? If not do we want/need an all_with_unlisted_and_enterprise? Either way the docs should mention the behaviour.
• if all_with_unlisted is going to include enterprise versions in v5, should it also include enterprise versions in v4 and v3? i.e. if the no-enterprise gate is active, should this queryset exclude enterprise versions?

[chrstinalin]

RE: The comment above this section;

    # filter in use. When fetching a single instance however, we use the
    # same queryset as the less restrictive filter, that allows us to see
    # all versions, even deleted ones. In any case permission checks will
    # prevent access if necessary (meaning regular users will never see
    # deleted or unlisted versions regardless of the queryset being used).

I imagine it would be more consistent with the intent to include enterprise versions in v5, and consistent with the rest of the code to gate it for v3/v4?

[eviljeff]

Depends really if we want consistency across the version of the api - so enterprise is available everywhere in v5, but unavailable everywhere in v3 and v4. Or across the add-on, so no matter which version of the api you use, once submitted, the enterprise versions would be in the list of versions.

Really a question for Product if not already specified in the PRD/issues, but imo, I don't think we gain anything from preventing those versions from being exposed to developers in the api responses. Going further, maybe we don't need the api gate either - i.e. does it matter if someone used v3 with filter=enterprise_only? 🤷

[eviljeff]

r+wc if we don't care about developers using v3/v4 and seeing enterprise versions we could strip out some of the extra complexity with the new api gate🤷