Fix Windows DLL install location#98
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## ros2 #98 +/- ##
=======================================
Coverage 68.21% 68.21%
=======================================
Files 3 3
Lines 607 607
=======================================
Hits 414 414
Misses 193 193 Continue to review full report at Codecov.
|
rhaschke
approved these changes
Jan 17, 2022
This was referenced Jun 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#91 changed the installation location of the DLL from the lib folder to the bin folder, but it was changed back to the lib folder in #96.
The DLL needs to be installed in the bin folder because only the bin folder is searched when looking for DLLs, not the lib folder. This same pattern of installing the DLL to the bin folder is also done in MoveIt2. Here is an example.