Skip to content

[issue-810] updated push-trigger.yml to fix github action build issue - #812

Merged
mayuradesh merged 1 commit into
mosip:release-1.4.0from
Prafulrakhade:release-1.4.0-810
Jul 20, 2026
Merged

[issue-810] updated push-trigger.yml to fix github action build issue#812
mayuradesh merged 1 commit into
mosip:release-1.4.0from
Prafulrakhade:release-1.4.0-810

Conversation

@Prafulrakhade

@Prafulrakhade Prafulrakhade commented Jul 20, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Updated the automated code-quality analysis workflow to use the latest development version.
    • Simplified the workflow configuration while preserving existing secret handling.

Signed-off-by: Prafulrakhade <prafulrakhade02@gmail.com>
@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The sonar-analysis job now references the reusable workflow from develop and passes only SERVICE_LOCATION, while existing secrets remain unchanged.

Changes

Sonar analysis workflow

Layer / File(s) Summary
Update Sonar workflow configuration
.github/workflows/push-trigger.yml
The reusable workflow reference changes from master to develop, and the SONAR_URL and PROJECT_KEY inputs are removed while SERVICE_LOCATION and existing secrets remain.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Poem

Sonar follows develop’s bright trail,
Two inputs drift beyond the veil.
Service location stays in flight,
Secrets remain tucked safely tight.
A smaller workflow, running right.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the workflow update in push-trigger.yml and its intent to fix the GitHub Actions build issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/push-trigger.yml:
- Line 51: Update the reusable workflow reference in push-trigger.yml to replace
the mutable `@develop` ref with the reviewed immutable commit SHA for
mosip/kattu’s npm-sonar-analysis.yml workflow. Preserve the existing workflow
path and inputs while ensuring the selected SHA is the approved audited
revision.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 7dd068be-0d9e-4395-9e03-0d829ab70f52

📥 Commits

Reviewing files that changed from the base of the PR and between 073deea and c0e0649.

📒 Files selected for processing (1)
  • .github/workflows/push-trigger.yml

Comment thread .github/workflows/push-trigger.yml
@mayuradesh
mayuradesh merged commit b13a1a2 into mosip:release-1.4.0 Jul 20, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants