Skip to content

ensure timely cleanup of UserAgent temporary files #2300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dakkar wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −1
Open

ensure timely cleanup of UserAgent temporary files #2300

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7181e33
ensure timely cleanup of UserAgent temporary files
dakkar Jan 6, 2026
9f1a638
move tests to a subtest
dakkar Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Mojo/UserAgent.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ sub _finish {
# CONNECT requests always have a follow-up request
$self->_reuse($id, $close) unless uc $old->req->method eq 'CONNECT';
$res->error({message => $res->message, code => $res->code}) if $res->is_error;
$c->{cb}($self, $old) unless $self->_redirect($c, $old);
(delete $c->{cb})->($self, $old) unless $self->_redirect($c, $old);
}

sub _process {
Expand Down
11 changes: 11 additions & 0 deletions t/mojo/user_agent.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,17 @@ ok $tx->res->headers->content_length, 'has "Content-Length" value';
ok !$tx->is_empty, 'transaction is not empty';
is $tx->res->body, 'x' x 262144, 'right content';

# memory->file asset promotion, plus timely cleanup
{
local $ENV{MOJO_MAX_MEMORY_SIZE} = 262144/2;
$tx = $ua->get('/huge');
}
is $tx->res->body, 'x' x 262144, 'right content';
my $filename = $tx->res->content->asset->path;
ok $filename, 'the huge body should be saved to a temporary file';
undef $tx;
ok !(-e $filename), 'the temporary file should be deleted as soon as the transaction is destroyed';
Comment thread
dakkar marked this conversation as resolved.
Outdated

# Non-blocking form
($success, $code, $body) = ();
$ua->post(
Expand Down
Loading