Avoid using $_ when loading the commands from namespaces

[bbrtj]

Summary

Solution proposed in #2175

Motivation

Polluting $_ can happen deep down in dependencies tree of the loaded command.

References

resolves #2175

[Copilot]

Pull Request Overview

This PR refactors the command-loading loop to avoid using the implicit $_, preventing unintended global variable pollution.

• Replaced a chained grep/for using $_ with an explicit for my $pkg loop.
• Added an early next unless _command($pkg) guard.
• Updated the hash assignment to use the named $pkg variable.

Comments suppressed due to low confidence (3)

lib/Mojolicious/Commands.pm:68

• [nitpick] Consider renaming $pkg to a more descriptive name like $module or $command_class to clarify that it represents a command class.

for my $pkg (find_modules($ns), find_packages($ns)) {

lib/Mojolicious/Commands.pm:67

• [nitpick] Add a comment explaining that this loop avoids using $_ to prevent pollution from upstream code, clarifying the purpose of the refactoring.

for my $ns (@{$self->namespaces}) {

lib/Mojolicious/Commands.pm:71

• Consider adding a test case to verify that command loading no longer pollutes $_, ensuring this transformation addresses the original issue (#2175).

}

[bbrtj]

Bump, why isn't this merged? Seems like a low-hanging fruit.

[kraih]

Nobody will even look at it before tests passed,

[bbrtj]

I'm confused. Am I required to take any action here? Did the tests fail? They look like they never ran at all.

[kraih]

No idea what went wrong i'm afraid, and nothing we can do about it.

[bbrtj]

I rebased to latest main. Seems like workflows await approval now. Maybe that'll fix them.

[bbrtj]

Most tests passed now. Windows test seems to be failing in other PRs too, regardless of their content.