Fix uninitialized value warning for failed jobs without timestamps in admin UI - #146
Open
SAY-5 wants to merge 1 commit into
Open
Fix uninitialized value warning for failed jobs without timestamps in admin UI#146SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
… admin UI Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A
failedjob that never started (for example one failed while still queued, withstartedandfinishedboth empty) makes the admin jobs list render$job->{finished} - $job->{started}on two undefined values, producingUse of uninitialized value in subtraction (-) at template minion/jobs.html.ep line 135. This computes and shows the runtime cell only when bothstartedand the end timestamp are defined; otherwise the job falls through to the existing waiting cell.Motivation
The warning shows up in the web admin at
/minion/jobs?state=failedfor such jobs, as reported in #145. The duration column has no meaningful value when a job has no start/end times, so guarding the subtraction avoids the noise and keeps the runtime cell reserved for jobs that actually ran.References
Fixes #145