Skip to content

feat(vtk): include all arrays on pathline input - #2161

Merged
wpbonelli merged 1 commit into
modflowpy:developfrom
wpbonelli:vtk-pls
Apr 19, 2024
Merged

feat(vtk): include all arrays on pathline input#2161
wpbonelli merged 1 commit into
modflowpy:developfrom
wpbonelli:vtk-pls

Conversation

@wpbonelli

Copy link
Copy Markdown
Member

Instead of hardcoding which arrays to include in vtk pathline export, include all numeric arrays present in the pathline data

@codecov

codecov Bot commented Apr 19, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 71.0%. Comparing base (029a4e1) to head (1489e0e).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #2161     +/-   ##
=========================================
+ Coverage     68.3%   71.0%   +2.7%     
=========================================
  Files          260     260             
  Lines        57947   58139    +192     
=========================================
+ Hits         39611   41330   +1719     
+ Misses       18336   16809   -1527     
Files Coverage Δ
flopy/export/vtk.py 78.0% <53.3%> (+9.7%) ⬆️

... and 177 files with indirect coverage changes

@wpbonelli
wpbonelli marked this pull request as ready for review April 19, 2024 16:21
@wpbonelli
wpbonelli merged commit 43cbe47 into modflowpy:develop Apr 19, 2024
@wpbonelli
wpbonelli deleted the vtk-pls branch April 19, 2024 16:22
@wpbonelli wpbonelli added this to the 3.7.0 milestone Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant