fix: enable task support on counter long_task example#838
Open
fix: enable task support on counter long_task example#838
Conversation
github-actions
Bot
added
T-CI
DaleSeo
force-pushed
the
fix/issue-836-counter-long-task-test
branch
from
75aa0c9 to
7815e38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #836
Motivation and Context
Fixed the
Counterexample's unit test by addingexecution(task_support = "optional"). Also widened the example test step in CI to--all-targetsto avoid the same issue.How Has This Been Tested?
The tests pass with the fix.
Breaking Changes
None.
Types of changes
Checklist