Skip to content

ci: deploy docs via GitHub Actions to py.sdk.modelcontextprotocol.io #2632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maxisbey wants to merge 1 commit into from
+61 −36

ci: deploy docs via GitHub Actions to py.sdk.modelcontextprotocol.io

aa4aba6
Select commit
Loading
Failed to load commit list.
Closed

ci: deploy docs via GitHub Actions to py.sdk.modelcontextprotocol.io #2632

ci: deploy docs via GitHub Actions to py.sdk.modelcontextprotocol.io
aa4aba6
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed May 18, 2026 in 2m 50s

Code review found 1 potential issue

Found 5 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit .github/workflows/deploy-docs.yml:9-11 cancel-in-progress: true contradicts GitHub Pages deployment guidance

Annotations

Check warning on line 11 in .github/workflows/deploy-docs.yml

See this annotation in the file changed.

@claude claude / Claude Code Review

cancel-in-progress: true contradicts GitHub Pages deployment guidance 

GitHub's official Pages starter workflows set `cancel-in-progress: false` for the deploy concurrency group, with the rationale that production Pages deployments should be allowed to complete rather than be cancelled mid-flight — and the TypeScript SDK workflow this PR cites as prior art does the same. Consider flipping this to `false` so a second push to `main` queues behind an in-progress deploy instead of cancelling it.
View more details on Claude