Removed sqare roughness from principled material conversion - #151
Open
BritishTeapot wants to merge 1 commit into
Open
Removed sqare roughness from principled material conversion#151BritishTeapot wants to merge 1 commit into
BritishTeapot wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the incorrect conversion of roughness values in principled BSDFs. The old code wrongly assumed Mitsuba 3 uses alpha for roughness, and blender uses sqrt roughness. However, in reality both of them use sqrt roughness. For more detail, see #122 .
This PR removes the squaring of blender's roughness values when converting to principled BSDF.