refactor: pass the Learn Fastly service ID at the call sites - #3804
Open
ChristopherChudzicki wants to merge 1 commit into
Open
Conversation
OpenAPI ChangesShow/hide changesUnexpected changes? Ensure your branch is up-to-date with |
ChristopherChudzicki
added a commit
that referenced
this pull request
Jul 30, 2026
Keeps the enqueued Celery message a single positional argument so a rolling deploy is safe in both directions: an old webapp's one-arg message runs on a new worker and still purges via the fallback, and a new webapp's one-arg message runs on an old worker unchanged. Passing service_id explicitly from the call sites is #3804, once every worker accepts the argument. Also drives cms/signals_test.py through Wagtail's real publish rather than calling the receiver directly, so the page_published.connect() wiring is covered. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Now that every worker accepts service_id, pass it explicitly so a purge's target is visible where it is enqueued -- an MITxOnline signal purging MIT Learn's Fastly service is surprising enough to name at the call site. Requires the parent PR to be fully deployed first: a two-argument message raises TypeError on a worker whose task still takes one argument. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ChristopherChudzicki
force-pushed
the
fix/fastly-learn-service-id-env-var
branch
from
July 30, 2026 14:57
36fcddc to
221cae9
Compare
ChristopherChudzicki
force-pushed
the
fix/fastly-pass-learn-service-id-explicitly
branch
from
July 30, 2026 14:57
fa59fc5 to
ecb236f
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Refs https://github.com/mitodl/hq/issues/12381
Description (What does it do?)
Naming clarity only: passes
settings.MIT_LEARN_FASTLY_SERVICE_IDexplicitly at the three call sites, so it's visible at the point of enqueue that an MITxOnline signal purges MIT Learn's Fastly service and not our own.Originally part of #3794, split out because a two-argument Celery message raises
TypeErroron a worker still running the one-argument task. #3794 keeps the message single-argument and falls back to the setting, which is safe in both rolling-deploy directions; this PR adds the argument back once every worker accepts it.Warning
Do not merge until #3794 is fully released — web and celery.