fix: Handle payment gateway refund errors in admin - #3803
Open
sentry[bot] wants to merge 2 commits into
Open
Conversation
OpenAPI ChangesShow/hide changesUnexpected changes? Ensure your branch is up-to-date with |
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a try-except block around the
refund_ordercall in the Django admin refund view (ecommerce/admin.py).Previously, if the underlying payment gateway (e.g., CyberSource) returned an unexpected error response format (such as a 401 Unauthorized error which lacks a top-level 'reason' key), it would lead to a
KeyErrorand an unhandled 500 error in the admin interface.This change catches any exceptions raised by the payment gateway during a refund attempt and displays a user-friendly error message to the admin, preventing a server error and providing better feedback. It also logs the full exception for debugging purposes.
This change complements a fix in
mitol-django-payment-gatewaythat makes theperform_refundmethod more robust against varied error response structures from CyberSource.Fixes MITXONLINE-6WC