Fix blurry UI on macOS and zziplib configure error with autoconf 2.70+#409
Open
damianoviscardi wants to merge 1 commit into
Open
Fix blurry UI on macOS and zziplib configure error with autoconf 2.70+#409damianoviscardi wants to merge 1 commit into
damianoviscardi wants to merge 1 commit into
Conversation
MTTrackerView: re-apply GL_NEAREST filter params after glGenerateMipmap() each frame. The Metal-backed OpenGL driver on modern macOS silently resets texture filter parameters to their defaults (GL_NEAREST_MIPMAP_LINEAR / GL_LINEAR) when glGenerateMipmap() is called, causing the UI to render with bilinear interpolation instead of nearest-neighbor and appearing blurry compared to previous versions. zziplib: the AX_CHECK_ALIGNED_ACCESS_REQUIRED m4 macro uses the deprecated AC_TRY_RUN which, with autoconf 2.70+, generates nested case constructs that produce a 'syntax error near unexpected token ;;' in /bin/sh on macOS, preventing zziplib from configuring. Fix by shipping a patched copy of the macro (replacing AC_TRY_RUN with AC_RUN_IFELSE + AC_LANG_PROGRAM) and copying it into the submodule via ExternalProject PATCH_COMMAND before autoreconf runs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
damianoviscardi
force-pushed
the
fix/macos-opengl-nearest-filter
branch
from
a4fde82 to
3e29278
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GL_NEARESTtexture filter parameters after eachglGenerateMipmap()call inMTTrackerView.mm. The Metal-backed OpenGL driver on modern macOS silently resets texture filter parameters to their defaults (GL_NEAREST_MIPMAP_LINEAR/GL_LINEAR) whenglGenerateMipmap()is called — causing the UI to render with bilinear interpolation instead of nearest-neighbor and appearing blurry compared to previous versions.AC_TRY_RUNmacro withAC_RUN_IFELSE+AC_LANG_PROGRAMinm4/ax_check_aligned_access_required.m4. autoconf 2.70+ generates nestedcaseconstructs fromAC_TRY_RUNthat produce asyntax error near unexpected token ';;'in/bin/shon macOS, preventing zziplib from configuring.Test plan
🤖 Generated with Claude Code